Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for client TLS auth to Mysql instances #2293

Open
srinivasmohan opened this issue Jan 12, 2023 · 3 comments
Open

Support for client TLS auth to Mysql instances #2293

srinivasmohan opened this issue Jan 12, 2023 · 3 comments

Comments

@srinivasmohan
Copy link

srinivasmohan commented Jan 12, 2023

Hi,
Thanks for building/maintaining sqlx! I have a use-case for client connections using TLS auth in my infra and I cant find an open feature request. I have a working change-set to implement this for rustls. Mind if I were to send a PR? Essentially, adds MySqlConnectOptions.ssl_client_cert() to allow rustls mode configure_tls_connector to load up the client cert during connection time.

Is your feature request related to a problem? Please describe.
Lack of SSL client auth for mysql clients

Describe the solution you'd like
Option to pass a combined PEM file via MySqlConnectOptions.ssl_client_cert() that gets used by the TLS Connector.

Describe alternatives you've considered
I did consider mysql_async crate but I liked the semantics of sqlx better.

Additional context
NA

@srinivasmohan
Copy link
Author

I should have looked at pending PRs earlier - Looks like #1850 does this too. Any progress on it?

@srinivasmohan
Copy link
Author

I also have a minimal working changeset https://github.com/srinivasmohan/sqlx/tree/mysql_ssl_client_auth which implements this for mysql/rustls alone (tests pending). (I dont have a need for native-tls feature but happy to implement that if needed).

@ThibsG
Copy link
Contributor

ThibsG commented Feb 18, 2023

Hi @srinivasmohan , PR #1850 just got merged into 0.7-dev. I didn't have time to look into combined PEM files and how to integrate them.

I guess this issue can be reworded into something more related to combined PEM files then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants