fix: Add missing privacy tracking fields in manifest #362
Conversation
|
This pull request has been linked to Shortcut Story #238604: Fix privacy manfiest packaging. |
| @@ -2,6 +2,10 @@ | |||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | |||
| <plist version="1.0"> | |||
| <dict> | |||
| <key>NSPrivacyTracking</key> | |||
| <false/> | |||
| <key>NSPrivacyTrackingDomains</key> | |||
There was a problem hiding this comment.
If you set NSPrivacyTracking to true then you need to provide at least one internet domain in NSPrivacyTrackingDomains; otherwise, you can provide zero or more domains.
Is this meant to be for analytic events?
There was a problem hiding this comment.
I think we should be okay here, the definition of tracking from the site doesn't seem to apply to analytics events:
Tracking refers to the act of linking user or device data collected from your app with user or device data collected from other companies’ apps, websites, or offline properties for targeted advertising or advertising measurement purposes. Tracking also refers to sharing user or device data with data brokers.
There was a problem hiding this comment.
I misread the other property.
🤖 I have created a release *beep* *boop* --- ## [9.6.1](9.6.0...9.6.1) (2024-04-02) ### Bug Fixes * Add missing privacy manifest resource for SPM ([#360](#360)) ([48f06cf](48f06cf)) * Add missing privacy tracking fields in manifest ([#362](#362)) ([7439997](7439997)) * Add objective-c binding for `LDConfig.logger` ([#365](#365)) ([eae8d78](eae8d78)) * Deprecate calling `start` without a timeout parameter ([#364](#364)) ([65d88a4](65d88a4)) * Use resource_bundle for privacy manifest in podspec ([#361](#361)) ([971a4c4](971a4c4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: LaunchDarklyReleaseBot <LaunchDarklyReleaseBot@launchdarkly.com>
The documentation seems to suggest you should set all 4 of these fields. So I'm doing that for completeness.