feat: Add auto create step in UI #10
Conversation
|
This pull request has been linked to Shortcut Story #236003: create stubbed out screen to auto-create project, environment, flag. |
* ci: add publish action to release-please workflow * feat: add required go-versions * remove unnecessary setup steps, go-versions
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix: uncomment conditional for release-ldcli
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix: Update release-please.yml to dry-run: false This reverts commit ea3c089.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
`ldcli projects list` returns list of projects in JSON
sunnyguduru
changed the title
| if m.currStep > flagsStep { | ||
| return fmt.Sprintf("envKey is %s, projKey is %s, flagKey is %s", m.currEnvironmentKey, m.currProjectKey, m.currFlagKey) | ||
| } | ||
|
|
||
| return fmt.Sprintf("\nstep %d of %d\n"+m.steps[m.currStep-1].View(), m.currStep, len(m.steps)) | ||
| return fmt.Sprintf("\nstep %d of %d\n"+m.steps[m.currStep].View(), m.currStep+1, len(m.steps)) |
There was a problem hiding this comment.
Got a little confused here. But basically we're rendering the current step's view. While showing what step we're on in the header out of the total number of steps.
Was able to use currStep instead of currStep-1 since I got rid of the initial step.
| case projectsStep: | ||
| projModel, _ := m.steps[m.currStep-1].Update(msg) | ||
| projModel, _ := m.steps[projectsStep].Update(msg) |
There was a problem hiding this comment.
I think it makes sense to just directly use projectsStep here. Since the case is already ensuring we're on projectsStep. Same for the other cases
internal/setup/autoCreate.go
Outdated
| func NewAutoCreate() autoCreateModel { | ||
| choices := []choice{ | ||
| { | ||
| Key: "yes", |
There was a problem hiding this comment.
We probably only need the name here and the check later on could be for "Yes" instead of "yes".
internal/setup/autoCreate.go
Outdated
| @@ -0,0 +1,116 @@ | |||
| package setup | |||
There was a problem hiding this comment.
Can you rename the file auto_create.go to be more idiomatic?
sunnyguduru
deleted the
sunny/sc-236003/create-stubbed-out-screen-to-auto-create
branch
Auto Create is now the initial step.
The steps are the following:
Screenshot:
Video:
https://share.cleanshot.com/bdhRcswf