Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ldcli formula to homebrew-tap #108

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

sunnyguduru
Copy link
Contributor

@sunnyguduru sunnyguduru commented Apr 2, 2024

  • add ldcli to our existing homebrew tap

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Provide links to any issues in this repository or elsewhere relating to this pull request.

Describe the solution you've provided

Provide a clear and concise description of what you expect to happen.

Describe alternatives you've considered

Provide a clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context about the pull request here.

Copy link

This pull request has been linked to Shortcut Story #234870: Publish homebrew tap.

@sunnyguduru sunnyguduru changed the title Add ldcli formula to homebrew-tap feat: add ldcli formula to homebrew-tap Apr 2, 2024
Copy link

@InTheCloudDan InTheCloudDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's been awhile for me with code-refs, but comparing the files looks good to me. Are we going to use goreleaser to also push the docker containers?

Also were you able to test this locally? I think code refs is using an old version of it so just want to make sure there hasn't been any breaking changes.

@sunnyguduru
Copy link
Contributor Author

it's been awhile for me with code-refs, but comparing the files looks good to me. Are we going to use goreleaser to also push the docker containers?

Also were you able to test this locally? I think code refs is using an old version of it so just want to make sure there hasn't been any breaking changes.

I have another PR up for using goreleaser to do the docker containers actually. I'll reach out to you

@sunnyguduru sunnyguduru merged commit 1d638dc into main Apr 3, 2024
2 checks passed
@sunnyguduru sunnyguduru deleted the sunny/sc-234870/publish-homebrew-tap branch April 3, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants