feat: Can go back to choose SDK page from show SDK instructions #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #239052: go back from choose SDK step in setup. |
dbolson
commented
Apr 3, 2024
| flagsClient flags.Client | ||
| quitMsg string // TODO: set this? | ||
| quitting bool | ||
| sdk sdkDetail |
There was a problem hiding this comment.
Added this and sorted the others.
| cmd = m.currentModel.Init() | ||
| m.sdkKind = msg.sdkKind | ||
| m.sdk = msg.sdk |
There was a problem hiding this comment.
I'm passing the entire sdk details instead of its fields.
k3llymariee
approved these changes
Apr 3, 2024
internal/quickstart/container.go
Outdated
Comment on lines
149
to
152
| Back: key.NewBinding( | ||
| key.WithKeys("left"), | ||
| key.WithHelp("back", "go back"), | ||
| ), |
There was a problem hiding this comment.
is it weird to use left here when we were just using it to traverse the the list in the previous step? do we not want to use esc?
internal/quickstart/container.go
Outdated
| m.currentStep += 1 | ||
| case selectedSDKMsg: | ||
| m.currentModel, cmd = m.currentModel.Update(msg) |
There was a problem hiding this comment.
could this be grouped with the case statement for the msg's on line 95?
dbolson
force-pushed
the
sc-239052/go-back-a-step
branch
from
d698e6f
to
3136db5
Compare
This was referenced Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user can go back to choose another SDK once they're on the instructions page. We should show this in the help text once we have that.
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.