feat: make sdk instructions scrollable #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k3llymariee
commented
Apr 9, 2024
| @@ -112,6 +112,7 @@ func (m ContainerModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) { | |||
| m.flagKey = msg.flag.key | |||
| m.currentStep += 1 | |||
| m.err = nil | |||
| cmd = sendEnableMouseCellMotionMsg() | |||
There was a problem hiding this comment.
we can either enable this here as a message or at the start of the quickstart program, thought it was safer to enable here?
There was a problem hiding this comment.
I think it's better here too. Since we don't use the feature elsewhere
Comment on lines
+15
to
+18
| const ( | ||
| viewportWidth = 80 | ||
| viewportHeight = 30 | ||
| ) |
There was a problem hiding this comment.
arbitrary values I picked - we could adjust these based on the window size if we want?
k3llymariee
commented
Apr 9, 2024
Comment on lines
+96
to
+100
| md, err := m.renderMarkdown() | ||
| if err != nil { | ||
| return m, sendErr(err) | ||
| } | ||
| m.viewport.SetContent(md) |
There was a problem hiding this comment.
rendering once here vs. every time the View method is called, to allow for proper updating
sunnyguduru
approved these changes
Apr 9, 2024
dbolson
approved these changes
Apr 9, 2024
This was referenced Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scrollable-sdk.mp4
Adds a viewport for displaying the SDK instructions, which should be scrollable both with up/down keys as well as a mouse wheel.