feat: Use new sdk instructions instead of hello READMEs #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k3llymariee
commented
Apr 9, 2024
|
|
||
| # Create a helper function for rendering messages. | ||
| def show_message(s): | ||
| print("*** {}".format(s)) |
There was a problem hiding this comment.
I did change the string formatting from what's shown in the quickstart because our rendering was trying/failing to find the %s values and instead was showing MISSING values
before:
print("*** %s" % s)
| return errMsg{err: err} | ||
| } | ||
|
|
||
| return fetchedSDKInstructions{instructions: content} |
There was a problem hiding this comment.
despite the name of the function we're still sending fetchedSDKInstructions message type - figured we can update either the message name or the function name when we stop fetching from the READMEs but this way we can still just handle this one message in the showSDKInstructionsModel.Update method.
Comment on lines
+1
to
+5
| # Set up your application | ||
|
|
||
| If you want to skip ahead, the final code is available in our [GitHub repository](https://github.com/launchdarkly/hello-python). | ||
|
|
||
|
|
There was a problem hiding this comment.
I think maybe when the instructions are all in we might want to pull this intro text out of the markdown file/viewport box
sunnyguduru
approved these changes
Apr 9, 2024
dbolson
approved these changes
Apr 9, 2024
k3llymariee
deleted the
kelly/sc-239433/use-new-sdk-instructions-instead-of-example
branch
This was referenced Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copies the instructions from the guided quickstart here as markdown files to render in the setup flow. Starting with just one SDK (python) to establish the pattern.