fix: remove mouse wheel support from show sdk & show scroll options in help view #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnyguduru
approved these changes
Apr 10, 2024
Comment on lines
+54
to
+55
| h := help.New() | ||
| h.ShowAll = true |
There was a problem hiding this comment.
Did we define help ourselves somewhere?
There was a problem hiding this comment.
this is just the bubbletea Help model
dbolson
approved these changes
Apr 10, 2024
|
@dbolson yeah I worry about hiding those keys/making it less obvious that it's scrollable. I don't hate it as-is 😅 but maybe we can wait for more feedback |
k3llymariee
deleted the
kelly/sc-239828/remove-mouse-wheel-support-from-show-sdk
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes mouse wheel support from the viewport, because with this enabled we're unable to highlight the text within to copy/paste (which is kinda the whole point of it).