feat: add remaining SDK instructions #164

k3llymariee · 2024-04-10T21:48:12Z

Adds the remaining hardcoded SDK instructions, based off of these gonfalon files. A followup PR will remove the extra logic we have that decides whether to fetch or read instructions.

k3llymariee · 2024-04-10T21:52:18Z

internal/sdks/sdk_instructions/android.md

+# Installation steps
+If you want to skip ahead, the final code is available in our [GitHub repository](https://github.com/launchdarkly/hello-android).


commented this on the last PR as well but I think we'll probably want to pull this out and add to the top of the View for the show sdk step instead of having them each in here.

Yeah, that makes sense.

internal/sdks/sdk_instructions/dotnet-client.md

k3llymariee · 2024-04-10T21:55:06Z

internal/quickstart/messages.go

@@ -176,13 +177,18 @@ func sendFetchEnv(accessToken string, baseUri string, key string, projKey string
 		var resp struct {
 			SDKKey       string `json:"apiKey"`
 			ClientSideId string `json:"_id"`
+			MobileKey    string `json:"mobileKey"`


pulling out the env's mobile key now as well

internal/sdks/sdk_instructions/apex-server.md

internal/sdks/sdk_instructions/c-client.md

internal/sdks/sdk_instructions/electron.md

internal/sdks/sdk_instructions/erlang.md

k3llymariee · 2024-04-11T20:45:22Z

internal/sdks/sdk_instructions/haskell-server.md

+
+You should see:
+
+`Feature flag my-flag-key is FALSE`


I don't know why but this last line isn't showing up for me in my terminal 🤔

I'm able to see it, even after changing the terminal height. 🤷

Actually I ran into a lot of inconsistency bugs when viewing these in the terminal. Lines duplicating. This line not showing. I figure it was a bug with our scrolling container. I think we should open a new ticket for that.

internal/sdks/sdk_instructions/lua-server.md

k3llymariee · 2024-04-11T20:50:20Z

internal/sdks/sdk_instructions/lua-server.md

+You should see:
+`Feature flag my-flag-key is FALSE for this context`


similar to haskell - these two last lines aren't showing up 🤔

Wonder if I'm failing to escape characters somewhere. I'll investigate

it might just be me if danny's able to see it 🤷‍♀️

Ok. I did see it too before. I was testing in the vscode terminal not in its own window

k3llymariee · 2024-04-11T20:51:58Z

internal/sdks/sdk_instructions/node-client.md

+You should see:
+`Feature flag my-flag-key is FALSE for this context`


missing lines 🤔

Sorry am I missing something here?

sorry no same thing that might just be me where i can't see these last lines

internal/sdks/sdk_instructions/roku.md

k3llymariee · 2024-04-11T21:05:37Z

internal/quickstart/choose_sdk.go

@@ -108,35 +108,36 @@ func (s sdkDetail) FilterValue() string { return "" }

 var SDKs = []sdkDetail{
 	{canonicalName: "react", displayName: "React", kind: clientSideSDK, hasInstructions: true},
-	{canonicalName: "node-server", displayName: "Node.js (server-side)", kind: serverSideSDK},
+	{canonicalName: "node-server", displayName: "Node.js (server-side)", kind: serverSideSDK, hasInstructions: true},


I'll add a follow up PR to remove this extra check now that we're no longer fetching these from the README's

dbolson

This looks good to go after a few small changes.

dbolson · 2024-04-11T21:22:19Z

internal/quickstart/choose_sdk.go

+	{canonicalName: "c-server", displayName: "C/C++ (server-side)", kind: serverSideSDK, hasInstructions: true},
+	{canonicalName: "lua-server", displayName: "Lua", kind: serverSideSDK, hasInstructions: true},
+	{canonicalName: "haskell-server", displayName: "Haskell", kind: serverSideSDK, hasInstructions: true},
+	{canonicalName: "apex-server", displayName: "Apex", kind: serverSideSDK, hasInstructions: true},


I think we can remove apex and electron since they're not in the UI SDK list.

dbolson · 2024-04-11T21:23:15Z

internal/sdks/sdk_instructions/android.md

+# Installation steps
+If you want to skip ahead, the final code is available in our [GitHub repository](https://github.com/launchdarkly/hello-android).


Yeah, that makes sense.

dbolson · 2024-04-11T21:24:15Z

internal/sdks/sdk_instructions/android.md

+class MainActivity : AppCompatActivity() {
+
+  // Set BOOLEAN_FLAG_KEY to the boolean feature flag you want to evaluate.
+  val BOOLEAN_FLAG_KEY = "my-flag-key"


Looks like we still have this bug in a couple places. We don't need to fix that in this PR, but could you fix it in a separate one?

internal/sdks/sdk_instructions/apex-server.md

internal/sdks/sdk_instructions/c-client.md

internal/sdks/sdk_instructions/dotnet-client.md

internal/sdks/sdk_instructions/erlang.md

dbolson · 2024-04-11T21:29:00Z

internal/sdks/sdk_instructions/haskell-server.md

+
+You should see:
+
+`Feature flag my-flag-key is FALSE`


I'm able to see it, even after changing the terminal height. 🤷

Co-authored-by: Kelly Hofmann <55991524+k3llymariee@users.noreply.github.com>

dbolson · 2024-04-11T21:35:40Z

internal/sdks/sdk_instructions/android.md

+              .name(getUserName())
+              .build()
+      } else {
+          LDContext.builder(ContextKind.DEFAULT, "example-user-key")


Can you change "example-user-key" to "my-flag-key" so it gets interpolated? This is the code that lists expected keys.

I believe this is the context key not a flag key. Which is why I left context key stuff alone. Correct me if I'm wrong @k3llymariee

yeah I'm pretty sure that's not a flag key/shouldn't be replaced

Got it. Makes sense.

k3llymariee added 13 commits April 10, 2024 11:24

add node-server instructions

e0590f0

add java instructions

088142b

add dotnet-server instructions

70024f8

add js instructions

9e56b43

add vue instructions

d064083

get mobile key, display in sdk instructions

defe0f4

add ios-swift instructions

9f4fd0a

add android instructions

fc72335

add go instructions

5035804

add react-native instructions

ab50150

add ruby instructions

47bad15

add flutter instructions

ad8d447

add dotnet-client instructions

7717fb2

k3llymariee commented Apr 10, 2024

View reviewed changes

merge main

abad0f0

k3llymariee commented Apr 10, 2024

View reviewed changes

Sunny Guduru added 10 commits April 10, 2024 16:19

added erlang

4a50799

added rust

f19733e

electron

b2e692d

added node-cleint

d946053

fix erlang default value

1833fa4

added lua-server

fbc6655

added haskell

969b40e

added php

a5c530a

added apex, roku, modified haskell

2905d17

added c server and client

edb87ea

sunnyguduru requested a review from dbolson April 11, 2024 19:52

Merge branch 'main' into kelly/sc-239433/more-sdk-instructions

9a96029

sunnyguduru marked this pull request as ready for review April 11, 2024 19:52

changed mobile key placeholder in c client

737c221

add header to react-native instructions

f44de40

k3llymariee commented Apr 11, 2024

View reviewed changes

k3llymariee mentioned this pull request Apr 11, 2024

chore: remove old sdk steps #167

Merged

dbolson reviewed Apr 11, 2024

View reviewed changes

Update lua-server.md

4ef0556

Co-authored-by: Kelly Hofmann <55991524+k3llymariee@users.noreply.github.com>

dbolson reviewed Apr 11, 2024

View reviewed changes

Sunny Guduru added 3 commits April 11, 2024 14:48

remove apex and electron

205e8db

fixed erlang string escaping

5b3faf7

remove callout in dotnet

184c45e

sunnyguduru requested a review from dbolson April 11, 2024 21:53

add another line between steps 2 and 3

a308d63

dbolson approved these changes Apr 11, 2024

View reviewed changes

sunnyguduru merged commit 284669d into main Apr 11, 2024
2 checks passed

sunnyguduru deleted the kelly/sc-239433/more-sdk-instructions branch April 11, 2024 23:01

github-actions bot mentioned this pull request Apr 10, 2024

chore(main): release 0.7.0 #153

Merged

sunnyguduru mentioned this pull request Apr 15, 2024

feat: add get subcommand to flag #180

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add remaining SDK instructions #164

feat: add remaining SDK instructions #164

k3llymariee commented Apr 10, 2024 •

edited

Loading

k3llymariee Apr 10, 2024

dbolson Apr 11, 2024

k3llymariee Apr 10, 2024

k3llymariee Apr 11, 2024

dbolson Apr 11, 2024

sunnyguduru Apr 11, 2024

k3llymariee Apr 11, 2024

sunnyguduru Apr 11, 2024

k3llymariee Apr 11, 2024

sunnyguduru Apr 11, 2024

k3llymariee Apr 11, 2024

sunnyguduru Apr 11, 2024

k3llymariee Apr 11, 2024 •

edited

Loading

k3llymariee Apr 11, 2024

dbolson left a comment

dbolson Apr 11, 2024

dbolson Apr 11, 2024

dbolson Apr 11, 2024

dbolson Apr 11, 2024

dbolson Apr 11, 2024

sunnyguduru Apr 11, 2024

k3llymariee Apr 11, 2024

dbolson Apr 11, 2024

		# Installation steps
		If you want to skip ahead, the final code is available in our [GitHub repository](https://github.com/launchdarkly/hello-android).

		You should see:
		`Feature flag my-flag-key is FALSE for this context`

feat: add remaining SDK instructions #164

feat: add remaining SDK instructions #164

Conversation

k3llymariee commented Apr 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k3llymariee Apr 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dbolson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k3llymariee commented Apr 10, 2024 •

edited

Loading

k3llymariee Apr 11, 2024 •

edited

Loading