feat: support env vars #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbolson
commented
Apr 12, 2024
| @@ -15,18 +15,39 @@ func TestGet(t *testing.T) { | |||
| errorHelp := ". See `ldcli environments get --help` for supported flags and usage." | |||
| mockArgs := []interface{}{ | |||
| "testAccessToken", | |||
| "https://app.launchdarkly.com", | |||
| "http://test.com", | |||
There was a problem hiding this comment.
Added this for consistency with the other tests so we can use the test helper.
| assert.JSONEq(t, `{"valid": true}`, string(output)) | ||
| }) | ||
|
|
||
| t.Run("with valid flags from environment variables calls API", func(t *testing.T) { |
There was a problem hiding this comment.
I'd like to refactor this since it's always the same for each command.
| "test-env", | ||
| "test-proj", | ||
| } | ||
| t.Run("with valid environments calls projects API", func(t *testing.T) { |
There was a problem hiding this comment.
"projects" was copy/pasted into all these tests.
| // Handle errors differently based on type. | ||
| // We don't want to show the usage if the user has the right structure but invalid data such as | ||
| // the wrong key. | ||
| SilenceErrors: true, | ||
| SilenceUsage: true, | ||
| } | ||
|
|
||
| viper.SetEnvPrefix("LD") |
There was a problem hiding this comment.
This is the main change.
| @@ -15,6 +16,7 @@ import ( | |||
| // Validate is a validator for commands to print an error when the user input is invalid. | |||
| func Validate() cobra.PositionalArgs { | |||
| return func(cmd *cobra.Command, args []string) error { | |||
| rebindFlags(cmd, cmd.ValidArgs) // rebind flags before validating them below | |||
There was a problem hiding this comment.
Validate gets called before any of the callback methods on a command, so we have to rebind this early to make sure the flags below are set with what's in viper. Otherwise, cobra doesn't know that the flags were set from environment variables.
sunnyguduru
approved these changes
Apr 12, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for environment variables defined as
LD_{key}wherekeyis all caps.Now you can run commands like this:
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.