feat: output in config #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbolson
commented
Apr 25, 2024
| @@ -98,7 +98,12 @@ func run() func(*cobra.Command, []string) error { | |||
| v.Set(key, value) | |||
| } | |||
|
|
|||
| return writeConfig(config.NewConfig(rawConfig), v, setKeyFn) | |||
| configFile, err := config.NewConfig(rawConfig) | |||
There was a problem hiding this comment.
This now can return an error.
| _, ok := validKinds[outputFlag] | ||
| if !ok { | ||
| return output.ErrInvalidOutputKind | ||
| _, err := output.NewOutputKind(outputFlag) |
There was a problem hiding this comment.
I moved the validation to a constructor function since it's used in a few places.
| func NewConfig(rawConfig map[string]interface{}) ConfigFile { | ||
| var accessToken string | ||
| func NewConfig(rawConfig map[string]interface{}) (ConfigFile, error) { | ||
| var ( |
There was a problem hiding this comment.
I moved these to one place and added the outputKind field.
| if rawConfig[cliflags.AnalyticsOptOut] != nil { | ||
| stringValue := rawConfig[cliflags.AnalyticsOptOut].(string) | ||
| analyticsOptOut, _ = strconv.ParseBool(stringValue) | ||
| stringValue := fmt.Sprintf("%v", rawConfig[cliflags.AnalyticsOptOut]) |
There was a problem hiding this comment.
This fixes
panic: interface conversion: interface {} is int, not string [recovered]
for some values.
| if rawConfig[cliflags.BaseURIFlag] != nil { | ||
| baseURI = rawConfig[cliflags.BaseURIFlag].(string) | ||
| } | ||
| if rawConfig[cliflags.OutputFlag] != nil { |
There was a problem hiding this comment.
This adds support to save the output flag.
| @@ -8,6 +8,30 @@ import ( | |||
|
|
|||
| var ErrInvalidOutputKind = errors.NewError("output is invalid") | |||
|
|
|||
| type OutputKind string | |||
There was a problem hiding this comment.
Add some stricter typing around this.
k3llymariee
approved these changes
Apr 25, 2024
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestNewConfig(t *testing.T) { |
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two things (please forgive me):
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.