feat: add hardcoded operation command with no body #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbolson
approved these changes
Apr 25, 2024
k3llymariee
commented
Apr 25, 2024
Comment on lines
+22
to
+29
| PersistentPreRun: func(cmd *cobra.Command, args []string) { | ||
| analyticsTracker.SendCommandRunEvent( | ||
| viper.GetString(cliflags.AccessTokenFlag), | ||
| viper.GetString(cliflags.BaseURIFlag), | ||
| viper.GetBool(cliflags.AnalyticsOptOut), | ||
| cmdAnalytics.CmdRunEventProperties(cmd, resourceName), | ||
| ) | ||
| }, |
There was a problem hiding this comment.
@sunnyguduru this look about right to you? I tested this and it seems to be working. also yes i did have resourceName hardcoded as a string for some reason initially, which is why ben saw those logs 😬
There was a problem hiding this comment.
Yeah that looks right!
sunnyguduru
approved these changes
Apr 25, 2024
k3llymariee
deleted the
kelly/sc-241151/hardcoded-operation-command-no-body
branch
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
admittedly this probably didn't need to be its own PR, but we've added logging!
adds
teams get --teamKey {team key}note that the flag is camelcase, but that's how it comes from the openapi spec. we'll update this once we do the generation of OperationDate from the OpenAPI spec (comment left)