feat: show pagination #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k3llymariee
approved these changes
May 10, 2024
dbolson
commented
May 10, 2024
| if len(maybeResources.Items) == 0 { | ||
| return "No items found", nil | ||
| } | ||
| if !isMultipleResponse { |
There was a problem hiding this comment.
Reversed this check to remove the indentation.
| limit int | ||
| offset int | ||
| ) | ||
| self, ok := maybeResources.Links["self"] |
There was a problem hiding this comment.
This gets the pagination values from the HATEOAS "self" link.
| } | ||
| } | ||
|
|
||
| if successMessage != "" { |
There was a problem hiding this comment.
I had to do some newline + space manipulation to make things work for a single response and multiple responses. We should refactor this to make it easier to reason about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a plaintext response that shows multiple items, we now show pagination if there is any.
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.