feat: break out required and optional flags in subcommand help #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
k3llymariee
commented
May 10, 2024
k3llymariee
commented
k3llymariee
commented
May 10, 2024
Comment on lines
+138
to
+140
| if strings.Contains(p.Value.Description, "Deprecated") { | ||
| continue | ||
| } |
There was a problem hiding this comment.
sneaking this in here as i noticed we had some deprecated flags in the cli
| {{WrappedOptionalFlagUsages . | trimTrailingWhitespaces}} | ||
|
|
||
| Global Flags: | ||
| {{rpad " -h, --help" 29}} Help for this command |
There was a problem hiding this comment.
it felt weird to include this within the "optional" flags, even though it's not technically a global flag it kinda is? lmk if we want to move this somewhere else
dbolson
approved these changes
May 10, 2024
cmd/templates.go
Outdated
| } | ||
|
|
||
| func init() { | ||
| cobra.AddTemplateFunc("WrappedRequiredFlagUsages", WrappedRequiredFlagUsages) |
There was a problem hiding this comment.
Could you move these to Execute() so we don't use init()?
k3llymariee
changed the title
k3llymariee
deleted the
kelly/sc-243521/split-up-optional-and-required-flags
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.