feat: track setup completed #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbolson
commented
May 10, 2024
| @@ -91,7 +91,7 @@ func (m ContainerModel) Init() tea.Cmd { | |||
|
|
|||
| func (m ContainerModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) { | |||
| var cmd tea.Cmd | |||
| var sendEvent bool | |||
| var shouldSendTrackingEvent bool | |||
There was a problem hiding this comment.
Renamed this for clarity.
| default: | ||
| // ignore other messages | ||
| } | ||
|
|
||
| if sendEvent { | ||
| cmd = tea.Batch(cmd, trackSetupStepStartedEvent(m.analyticsTracker, m.currentStep.String())) |
There was a problem hiding this comment.
Don't send this every time since toggling the flag will send it each time, not just when user gets to toggle flag page.
k3llymariee
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track "CLI Command Completed" event when user gets to toggle flag setup view.
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.