fix: update usage template to only show flags when present #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbolson
approved these changes
May 10, 2024
cmd/resources/resources.go
Outdated
| @@ -210,7 +210,7 @@ func NewResourceCmd( | |||
| }, | |||
| } | |||
|
|
|||
| cmd.SetUsageTemplate(getResourceUsageTemplate()) | |||
| cmd.SetUsageTemplate(OperationUsageTemplate()) | |||
There was a problem hiding this comment.
Is this still an accurate name, or should we rename it to not be resource- or operation-specific?
There was a problem hiding this comment.
yeah maybe SubcommandUsageTemplate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates the operation usage template to only show a header for required/optional flags if they're actually there. also removes the template for resources in favor of this singular template now.
truly don't know if this is the Best Way to handle this as I'm not familiar with templates, but it works!
before:
after:
and also resources work now too, though to be honest I don't know how
Flags:is showing up there 🤔