Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add archive flag cmd #287

Merged
merged 2 commits into from
May 15, 2024

Conversation

k3llymariee
Copy link
Contributor

@k3llymariee k3llymariee commented May 15, 2024

ldcli flags --help

Usage:
  ldcli flags [command]

Available Commands:
  archive                        Archive a feature flag
  copy                           Copy feature flag
  create                         Create a feature flag
  create-migration-safety-issues Get migration safety issues
  delete                         Delete feature flag
  get                            Get feature flag
  get-status                     Get feature flag status
  get-status-across-environments Get flag status across environments
  list                           List feature flags
  list-expiring-context-targets  Get expiring context targets for feature flag
  list-expiring-user-targets     Get expiring user targets for feature flag
  list-statuses                  List feature flag statuses
  toggle-off                     Turn a feature flag off
  toggle-on                      Turn a feature flag on
  update                         Update feature flag
  update-expiring-targets        Update expiring context targets on feature flag
  update-expiring-user-targets   Update expiring user targets on feature flag

ldcli flags archive --help

Archive a flag across all environments. It will only appear in your list when filtered for.

Usage:
  ldcli flags archive [flags]

Required flags:
      --flag string      The feature flag key. The key identifies the flag in your code.
      --project string   The project key

Global flags:
  -h, --help                  Get help about any command
      --access-token string   LaunchDarkly access token with write-level access
      --analytics-opt-out     Opt out of analytics tracking
      --base-uri string       LaunchDarkly base URI (default "https://app.launchdarkly.com")
  -o, --output string         Command response output format in either JSON or plain text (default "plaintext")

@k3llymariee k3llymariee requested a review from dbolson May 15, 2024 17:15
func NewArchiveCmd(client resources.Client) *cobra.Command {
cmd := &cobra.Command{
Args: validators.Validate(),
Long: "Archive a feature flag on",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what "on" means in this case. Maybe just, "Archive a feature flag"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeeeah that was probably just a copy/paste error thanks for checking 🙈

@k3llymariee k3llymariee merged commit 1c6f55b into main May 15, 2024
4 checks passed
@k3llymariee k3llymariee deleted the kelly/sc-243754/create-ldcli-flags-archive-alias branch May 15, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants