feat: validate access token #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbolson
commented
May 28, 2024
| @@ -38,10 +39,10 @@ func (cmd ConfigCmd) HelpCalled() bool { | |||
| return cmd.helpCalled | |||
| } | |||
|
|
|||
| func NewConfigCmd(analyticsTrackerFn analytics.TrackerFn) *ConfigCmd { | |||
| func NewConfigCmd(service config.Service, analyticsTrackerFn analytics.TrackerFn) *ConfigCmd { | |||
There was a problem hiding this comment.
Pass in the service so we can mock its HTTP client in tests.
| } | ||
|
|
||
| // VerifyAccessToken is true if the given access token is valid to make API requests. | ||
| func (s Service) VerifyAccessToken(accessToken string, baseURI string) bool { |
There was a problem hiding this comment.
I could move more of the config --set code into the config domain if it would make the cmd more readable.
| @@ -16,5 +21,9 @@ func (c *MockClient) MakeRequest( | |||
| ) ([]byte, error) { | |||
| c.Input = data | |||
|
|
|||
| if c.StatusCode > http.StatusBadRequest { | |||
There was a problem hiding this comment.
Added this for stubbing the HTTP client response.
k3llymariee
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting the access token in the config, check if it works by making an API request. If it's unauthorized, don't write to the config and tell the user.
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.