fix: Remove stutter from "fetching {sdk name} SDK SDK" #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbolson
changed the title
cwaldren-ld
reviewed
Aug 13, 2024
| @@ -156,7 +156,7 @@ func (m showSDKInstructionsModel) View() string { | |||
| } | |||
|
|
|||
| if m.instructions == "" || m.environment == nil { | |||
| return m.spinner.View() + fmt.Sprintf(" Fetching %s SDK instructions...\n", m.displayName) + footerView(m.help.View(m.helpKeys), nil) | |||
There was a problem hiding this comment.
Darn, I caught the one in the quickstart title but not this.
There was a problem hiding this comment.
Yeah, it's a bummer we don't have tests for the setup UI to catch stuff like this.
cwaldren-ld
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since switching to using the sdkmeta library, each SDK name has "SDK" in it. The placeholder for fetching the SDK instructions doesn't need "SDK" in it now.
This is what it looks like after the change:
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.