fix: LaunchDevly: Cleanup code and remove only show overrides when there are no overrides #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdelst
changed the title
cdelst
commented
Sep 12, 2024
| }), | ||
| ); | ||
|
|
||
| // Winnow out removed overrides and update local state in a | ||
| // single pass | ||
| const updatedOverrides = overrideKeys.reduce( |
There was a problem hiding this comment.
Turns out this was entirely unnecessary
cdelst
commented
Sep 12, 2024
| const flagsPerPage = 20; | ||
|
|
||
| const overridesPresent = useMemo( | ||
| () => overrides && Object.keys(overrides).length > 0, | ||
| [overrides], | ||
| ); | ||
|
|
||
| useEffect(() => { |
mike-zorn
approved these changes
Sep 13, 2024
Base automatically changed from
cdelst/sc-255978/pagination-functionality-bug
to
main
September 13, 2024 22:57
cdelst
force-pushed
the
cdelst/sc-255977/remove-override-bug
branch
from
c99294f
to
0ec83ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously you could get stuck in an error state where the "only show overrides" checkbox would get locked to on, and then disabled so that you couldn't edit it again due to having no overrides.
I solved this by adding a cheap useEffect hook that checks for this condition and directs us into a valid state.
I thought about hooking this in in various places to avoid the useEffect usage, but a global watcher for this component made the most sense to me.