fix: LaunchDevly UI: Add testing framework #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cdelst
commented
Oct 1, 2024
cdelst
commented
- Add testing framework and simple unit test as example.
- Add pre-commit checks that run the tests and make sure the UI is built
cdelst
changed the title
vroske-ld
approved these changes
Oct 1, 2024
internal/dev_server/ui/package.json
Outdated
| "scripts": { | ||
| "dev": "vite", | ||
| "build": "tsc -b && vite build", | ||
| "lint": "eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 0", | ||
| "prettier:write": "prettier . --write", | ||
| "preview": "vite preview" | ||
| "preview": "vite preview", | ||
| "test": "jest --config jest.config.mjs" |
There was a problem hiding this comment.
why not vite, since you're already using it to build the project? 😁
There was a problem hiding this comment.
ah very true, just used to it. Will change
cdelst
force-pushed
the
cdelst/FUN-277/add-test-framework-to-dev-server-ui
branch
from
8507bec
to
bb4b2db
Compare
cdelst
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.