fix: rebind projKey flag to update subcommand #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnyguduru
reviewed
Mar 25, 2024
| @@ -67,6 +67,9 @@ func runUpdate(cmd *cobra.Command, args []string) error { | |||
| viper.GetString("baseUri"), | |||
| ) | |||
|
|
|||
| // rebind flag to this subcommand | |||
| viper.BindPFlag("projKey", cmd.Flags().Lookup("projKey")) | |||
There was a problem hiding this comment.
Are we basically rebinding it before we pass the data in?
There was a problem hiding this comment.
I guess somewhere in the issue you linked I saw that since these are "local flags" for a subcommand they get overwritten
There was a problem hiding this comment.
Would be nice to have a helper function that rebinds all the flags were going to use/re-use or something since we're going to have a lot of subcommands.
sunnyguduru
approved these changes
Mar 25, 2024
| @@ -67,6 +67,9 @@ func runUpdate(cmd *cobra.Command, args []string) error { | |||
| viper.GetString("baseUri"), | |||
| ) | |||
|
|
|||
| // rebind flag to this subcommand | |||
| viper.BindPFlag("projKey", cmd.Flags().Lookup("projKey")) | |||
There was a problem hiding this comment.
Would be nice to have a helper function that rebinds all the flags were going to use/re-use or something since we're going to have a lot of subcommands.
dbolson
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
running into issues with duplicate flag names in different commands - rebinding the flag in the subcommand might not be the "right way" to do this but it works for now!
related issue: spf13/viper#233