feat: create prod-ready quickstart command #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #238058: create flag with name in setup wizard. |
dbolson
commented
Mar 27, 2024
|
|
||
| func runQuickStart(client flags.Client) func(*cobra.Command, []string) error { | ||
| return func(cmd *cobra.Command, args []string) error { | ||
| f, err := tea.LogToFile("debug.log", "") |
There was a problem hiding this comment.
I created a ticket to set up configurable logging.
| @@ -12,7 +12,7 @@ import ( | |||
| ) | |||
|
|
|||
| var setupCmd = &cobra.Command{ | |||
| Use: "setup", | |||
| Use: "setup-TOREMOVE", | |||
There was a problem hiding this comment.
We can keep this in so we can run the two setups in parallel for comparison until the new one is done.
| // represent a step in the quick-start flow. | ||
| type ContainerModel struct { | ||
| currentStep step | ||
| err error |
There was a problem hiding this comment.
We'll use these from the model that creates the flag so we can display them later.
| return "" | ||
| } | ||
|
|
||
| if m.err != nil { |
There was a problem hiding this comment.
This was trivial enough to add. Another ticket will make it look nice.
sunnyguduru
approved these changes
Mar 27, 2024
|
Make sure to add a title the conforms to conventional commit |
dbolson
changed the title
dbolson
changed the title
k3llymariee
approved these changes
Mar 27, 2024
* Add create flag step * Add flag name validation for quickstart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create container model to hold quickstart steps.