feat: better flag create error handling #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #238061: show error response when creating flag in setup wizard. |
dbolson
commented
Mar 28, 2024
| var ldErr *ldapi.GenericOpenAPIError | ||
| ok := errors.As(err, &ldErr) | ||
| // LDAPIError is an error from the LaunchDarkly API client. | ||
| type LDAPIError interface { |
There was a problem hiding this comment.
I couldn't test with GenericOpenAPIError because it has unexported fields and no constructor function. It does have the shape of this interface so we can implement our own error struct type for tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show a consistent JSON response when there's an error creating flags. Since the LD client doesn't return a body with a 401 response but does in other responses, we need to build our own body so there's always one to show the user.
The user can't re-enter the name yet.