feat: Show error along with message and quit if applicable #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #238061: show error response when creating flag in setup wizard. |
dbolson
commented
Mar 28, 2024
| @@ -49,13 +50,20 @@ func (m ContainerModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) { | |||
| case key.Matches(msg, keys.Enter): | |||
| switch m.currentStep { | |||
| case createFlagStep: | |||
| updated, _ := m.steps[createFlagStep].Update(msg) | |||
| updated, cmd := m.steps[createFlagStep].Update(msg) | |||
There was a problem hiding this comment.
Delegates the tea.Quit command. Seems cleaner?
There was a problem hiding this comment.
feels like we should leverage that functionality as much as possible!
| @@ -69,6 +72,18 @@ func (m createFlagModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) { | |||
| ) | |||
| if err != nil { | |||
| m.err = err | |||
| // TODO: we may want a more robust error type so we don't need to do this | |||
There was a problem hiding this comment.
Once we add more steps I'll refactor this.
k3llymariee
approved these changes
Mar 29, 2024
| @@ -49,13 +50,20 @@ func (m ContainerModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) { | |||
| case key.Matches(msg, keys.Enter): | |||
| switch m.currentStep { | |||
| case createFlagStep: | |||
| updated, _ := m.steps[createFlagStep].Update(msg) | |||
| updated, cmd := m.steps[createFlagStep].Update(msg) | |||
There was a problem hiding this comment.
feels like we should leverage that functionality as much as possible!
This was referenced Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show a "helpful" error message if the response is such that the user couldn't continue the setup flow.
This will print out eg.,