feat: Create choose SDK view #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #238063: create choose SDK view in setup wizard. |
k3llymariee
commented
Mar 28, 2024
| l.Styles.TitleBar = lipgloss.NewStyle() | ||
| l.SetShowPagination(true) | ||
| l.SetShowStatusBar(false) | ||
| l.SetFilteringEnabled(false) // TODO: try to get filtering working |
There was a problem hiding this comment.
Simply flipping this on to true doesn't work as expected - probably due to the fact that the container model is still delegating to this nested model.
I found this example of a simple list working with filtering, and got it to work on its own, but when I tried implementing those same changes in our delegated list model it still didn't work 😢
dbolson
approved these changes
Mar 28, 2024
sunnyguduru
approved these changes
Mar 28, 2024
This was referenced Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the second step to the quickstart flow to select an SDK. SDKs are sorted by most popular as determined by the following queries:
Which I then dumped into this google sheet to format for our purposes. It's a little manual but these don't change that often. We can also add whatever else we need to display the SDK instructions.
choose-an-sdk.mp4