fix: Add additional payload filter key validation #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were allowing any non-empty string value to be provided as a payload filter key. However, customers can only create a filter key with a subset of characters. In an effort to warn them earlier but potentially invalid configurations, we are adding some basic key validation work as part of the start up sequence.
keelerm84
commented
Sep 5, 2024
launchdarkly-server-sdk.gemspec
Outdated
| @@ -22,6 +22,7 @@ Gem::Specification.new do |spec| | |||
| spec.required_ruby_version = ">= 3.0.0" | |||
|
|
|||
| spec.add_development_dependency "aws-sdk-dynamodb", "~> 1.57" | |||
| spec.add_development_dependency "libxml-ruby", "~> 5.0", ">= 5.0.3" | |||
There was a problem hiding this comment.
Later versions of the aws sdk dynamodb gem seem to require you have this installed. This is only a dev dependency so we can add and remove at will here.
cwaldren-ld
reviewed
Sep 5, 2024
cwaldren-ld
approved these changes
Sep 5, 2024
keelerm84
pushed a commit
that referenced
this pull request
Oct 7, 2024
🤖 I have created a release *beep* *boop* --- ## [8.7.1](8.7.0...8.7.1) (2024-09-06) ### Bug Fixes * Add additional payload filter key validation ([#295](#295)) ([75d6c6a](75d6c6a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were allowing any non-empty string value to be provided
as a payload filter key. However, customers can only create a filter key
with a subset of characters.
In an effort to warn them earlier about potentially invalid
configurations, we are adding some basic key validation work as part of
the start up sequence.