Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building the app changes auto-generated files on Windows #10933

Open
laurent22 opened this issue Aug 27, 2024 · 1 comment
Open

Building the app changes auto-generated files on Windows #10933

laurent22 opened this issue Aug 27, 2024 · 1 comment
Labels
bug It's a bug desktop All desktop platforms medium Medium priority issues

Comments

@laurent22
Copy link
Owner

laurent22 commented Aug 27, 2024

Operating system

Windows

Joplin version

3.0

Desktop version info

No response

Current behaviour

It seems in some cases, building the app on Windows is going to change auto-generated files. This is most likely due to a newline issue - maybe due to the git autocrlf feature.

We should check under what condition it happens, and see what we can do to prevent it.

Those are the files being changed (probably just the index.ts files are relevant here).

image

Expected behaviour

No response

Logs

No response

@laurent22 laurent22 added bug It's a bug desktop All desktop platforms high High priority issues labels Aug 27, 2024
@personalizedrefrigerator
Copy link
Collaborator

personalizedrefrigerator commented Aug 27, 2024

For me, just one file is marked as changed when I run corepack yarn ; corepack yarn postinstall (Powershell, from the Joplin root directory):

PS C:\Users\User\Documents\GitHub\joplin> corepack yarn ; corepack yarn postinstall
...
PS C:\Users\User\Documents\GitHub\joplin> git status
HEAD detached at upstream/dev
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   packages/app-desktop/package.json

no changes added to commit (use "git add" and/or "git commit -a")

Additionally, git config get core.autocrlf returns input:

PS C:\Users\User\Documents\GitHub\joplin> git config get core.autocrlf
input

I'm on Windows 11.

@laurent22 laurent22 added medium Medium priority issues and removed high High priority issues labels Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug desktop All desktop platforms medium Medium priority issues
Projects
None yet
Development

No branches or pull requests

2 participants