added paths for web vs in image-hub sample app #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack. |
2 tasks
leecalcote
reviewed
Feb 23, 2021
kumarabd
reviewed
Feb 23, 2021
kumarabd
suggested changes
Feb 24, 2021
There was a problem hiding this comment.
@pranav-bhatt I would suggest no changes to the yaml currently as your change to match for / is not ideal. We want to support any route except for the api ones that are locked.
leecalcote
approved these changes
Mar 1, 2021
Signed-off-by: adpranavb2000@gmail.com <adpranavb2000@gmail.com>
Signed-off-by: adpranavb2000@gmail.com <adpranavb2000@gmail.com>
Signed-off-by: adpranavb2000@gmail.com <adpranavb2000@gmail.com>
kumarabd
approved these changes
Mar 4, 2021
|
Thanks for your contribution to the Layer5 community! 🎉
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #195
Signed-off-by: adpranavb2000@gmail.com adpranavb2000@gmail.com
Description
This PR fixes #195, by adding webpage paths to the web-vs situated in imagehub-gateway.yaml.
Signed commits