Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something goes wrong when saving claimtrie nodes to disk and loading it #133

Closed
kaykurokawa opened this issue May 6, 2018 · 2 comments · Fixed by #276
Closed

Something goes wrong when saving claimtrie nodes to disk and loading it #133

kaykurokawa opened this issue May 6, 2018 · 2 comments · Fixed by #276
Labels
needs: repro Issue needs step-by-step instructions on how to reproduce in latest code type: bug Existing functionality is wrong or broken

Comments

@kaykurokawa
Copy link

kaykurokawa commented May 6, 2018

Discovered in #110

When loading in claimtrie nodes using function InsertFromDisk() https://github.com/lbryio/lbrycrd/blob/master/src/claimtrie.cpp#L1072 , we discovered that for some reason the "name" variable contains an extra bogus character at the end.

However, I suspect that there is not always a bogus character attached to the "name" variable, thus this function will completely fail.

I've tested the serialization classes to see if there is any problem loading/saving string classes and there is no problem, so its likely a problem originating from when we save nodes, particularly when the function markNodeDirty() gets called https://github.com/lbryio/lbrycrd/blob/master/src/claimtrie.cpp#L828 which marks nodes to be saved on disk.

@kaykurokawa kaykurokawa self-assigned this May 6, 2018
@kaykurokawa kaykurokawa added type: bug Existing functionality is wrong or broken and removed needs: triage labels May 6, 2018
@kaykurokawa kaykurokawa changed the title Something wrong when saving nodes to disk and loading it Something goes wrong when saving claimtrie nodes to disk and loading it May 6, 2018
@bvbfan
Copy link
Collaborator

bvbfan commented Aug 2, 2018

This probably should be fixed when merging new code.

@alyssaoc alyssaoc added the needs: priority Priority level needs to be defined label Aug 21, 2018
@alyssaoc alyssaoc added needs: repro Issue needs step-by-step instructions on how to reproduce in latest code and removed needs: priority Priority level needs to be defined labels Oct 17, 2018
@BrannonKing
Copy link
Member

I'm closing this as unreproducible. The serialization code has been updated with the upstream merge. Also, the code for loading the trie will be different with the new memory improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: repro Issue needs step-by-step instructions on how to reproduce in latest code type: bug Existing functionality is wrong or broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants