Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nCurrentHeight in ClaimTrie and ClaimTrieCache needs to be renamed #138

Closed
kaykurokawa opened this issue May 14, 2018 · 5 comments · Fixed by #276
Closed

nCurrentHeight in ClaimTrie and ClaimTrieCache needs to be renamed #138

kaykurokawa opened this issue May 14, 2018 · 5 comments · Fixed by #276
Assignees
@bvbfan
Labels
type: refactor Minimal user-visible changes, but significant internal work
Milestone
Spring

Comments

@kaykurokawa
Copy link

kaykurokawa commented May 14, 2018 •
edited
Loading

nCurrentHeight, a member variable in ClaimTrie and ClaimTrieCache, is not the actual current height.
It is the current height + 1 (i.e, if there is a total of two blocks including the genesis, nCurrentHeight is 2 where as the standard definition of current height would be 1) , or perhaps it can be called as the current height "to be worked on".

nNextHeight might be a better name.
@kaykurokawa kaykurokawa added help wanted type: refactor Minimal user-visible changes, but significant internal work labels May 14, 2018
@kauffj
Copy link
Member

kauffj commented May 15, 2018

@kaykurokawa add comment until refactor happens?

@bvbfan
Copy link
Collaborator

bvbfan commented Jun 6, 2018

I can take it on my refactor branch, it's sound good?

@bvbfan
Copy link
Collaborator

bvbfan commented Jun 15, 2018

It is nNextHeight in my local branch i'll made pull request.

@kaykurokawa kaykurokawa mentioned this issue Jul 11, 2018
Closed
@bvbfan bvbfan self-assigned this Aug 2, 2018
@alyssaoc alyssaoc added needs: grooming Issue needs to be groomed before work can start and removed help wanted labels Sep 13, 2018
@alyssaoc
Copy link

alyssaoc commented Oct 4, 2018

@bvbfan Can this issue be closed?

@alyssaoc alyssaoc removed the needs: grooming Issue needs to be groomed before work can start label Oct 4, 2018
@bvbfan
Copy link
Collaborator

bvbfan commented Oct 4, 2018

Still not, i've plan to do RR, but i don't want to bother normalization work.

@BrannonKing BrannonKing added this to the Spring milestone Mar 8, 2019
@BrannonKing BrannonKing mentioned this issue May 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvbfan bvbfan

Labels
type: refactor Minimal user-visible changes, but significant internal work
Projects
None yet
Milestone
Spring
Development

Successfully merging a pull request may close this issue.

Memory improvements, claimtrie revamp lbryio/lbrycrd
6 participants
@kauffj @BrannonKing @kaykurokawa @bvbfan @alyssaoc @lbry-bot