Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo left in help info 0.17.2.1 #306

Closed
tiger5226 opened this issue Aug 22, 2019 · 6 comments
Closed

Todo left in help info 0.17.2.1 #306

tiger5226 opened this issue Aug 22, 2019 · 6 comments

Comments

@tiger5226
Copy link

Todo in help info

supportclaim "name" "claimid" "amount" "value"
Increase the value of a claim. Whichever claim has the greatest value, including all support values, will be the authoritative claim, according to the rest of the rules. The name is the name which is claimed by the claim that will be supported, the txid is the txid of the claim that will be supported, nout is the transaction output which contains the claim to be supported, and amount is the amount which will be added to the value of the claim. If the claim is currently the authoritative claim, this support will go into effect immediately . Otherwise, it will go into effect after 100 blocks. The support will be in effect until it is spent, and will lose its effect when the claim is spent or expires. The amount is a real and is rounded to the nearest .00000001

Arguments:
1. "name"  (string, required) The name claimed by the claim to support.
2. "claimid"  (string, required) The claimid of the claim to support. This can be obtained by TODO PUT IN PLACE THAT SHOWS THIS.
3. "amount"  (numeric, required) The amount in LBC to use to support the claim.
4. "value"  (string, optional) The metadata of the support encoded in hexadecimal.

Result:
"transactionid"  (string) The transaction id of the support.
@tiger5226
Copy link
Author

In addition to this, it would be best if these parameters were optional. Like supporting a name only. would make testing easier.

@bvbfan
Copy link
Collaborator

bvbfan commented Aug 23, 2019

Name + (partial) claimId, which specify a distinct claim, or best one.

@tiger5226
Copy link
Author

Just a name would be best with the option of passing a claimid to make it distinct.

@bvbfan
Copy link
Collaborator

bvbfan commented Sep 2, 2019

af9ecd4
Default amount is the minimum one 0.00000001.

@tiger5226
Copy link
Author

Sweet! @nikooo777 One this is in the release we can take out Chainquery as a dependency of the e2e test.

@BrannonKing
Copy link
Member

Merged via #303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants