Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC calls ignore locktime transactions #370

Open
BrannonKing opened this issue Feb 24, 2020 · 1 comment
Open

RPC calls ignore locktime transactions #370

BrannonKing opened this issue Feb 24, 2020 · 1 comment

Comments

@BrannonKing
Copy link
Member

Enable address decode and "is mine" for transactions containing the OP_CHECKLOCKTIMEVERIFY and OP_CHECKSEQUENCEVERIFY prefixes.

I'm not sure if should report something as spendable when the timelock has not yet elapsed, but we should afterward. Right now the "watch only" flag is required to see these.

@BrannonKing
Copy link
Member Author

listreceivedbyaddress shows them if you run importaddress on the redeemscript.

In reviewing the code again, multisig addresses are not considered non-standard. They are first-class citizens. Therefore the "is mine" code correctly handles them. The timelock stuff, on the other hand, falls down the "nonstandard transaction" path. Therefore, it is only monitored if it is explicitly marked as "watch only".

So that leaves three options:

  1. Make the timelock scripts first-class citizens.
  2. Automatically add them as "watch only" scripts in addtimelockedaddress.
  3. Rely on somebody who cares to call importaddress on the redeemscript.
    Option 1 is more involved. Option 3 requires no work. Option 2 and 3 rely on the "watch only" stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant