Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Macros #503

Open
nosracd opened this issue Apr 8, 2024 · 0 comments
Open

Empty Macros #503

nosracd opened this issue Apr 8, 2024 · 0 comments
Labels
2.0 Breaking API changes

Comments

@nosracd
Copy link
Contributor

nosracd commented Apr 8, 2024

The *_decode_array_cleanup macros defined in lcm/lcm_coretypes.h have an empty definition. For example:

#define __double_decode_array_cleanup(p, sz) \
    {                                        \
    }

This produces unused parameter warnings when compiling C code outputted from lcm-gen.

It looks like these macros should just be removed, but doing so would be a breaking change and not possible without incrementing the major release version.

@nosracd nosracd added the 2.0 Breaking API changes label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 Breaking API changes
Projects
None yet
Development

No branches or pull requests

1 participant