Go workspace support from Go 1.18

[gnuletik]

Here is a repo to reproduce

git clone https://github.com/gnuletik/gomoddirectives-repro
cd gomoddirectives-repro/
bash -c 'cd hello && golangci-lint cache clean && golangci-lint run --config ../.golangci-lint.yml'

It should show a warning:

WARN [linters context] running gomoddirectives failed: failed to get module file: unmarshaling error: invalid character '{' after top-level value: {
	"Path": "example.com/hello",
	"Main": true,
	"Dir": "/tmp/gomoddirectives-repro/hello",
	"GoMod": "/tmp/gomoddirectives-repro/hello/go.mod",
	"GoVersion": "1.18"
}
{
	"Path": "example.com/pkg",
	"Main": true,
	"Dir": "/tmp/gomoddirectives-repro/pkg",
	"GoMod": "/tmp/gomoddirectives-repro/pkg/go.mod",
	"GoVersion": "1.18"
}
: if you are not using go modules it is suggested to disable this linter

see golangci/golangci-lint#2752

[ldez]

Hello,

can you run the following command: go list -m -json

[gnuletik]

Thanks for the fast feedback!

There you go

$ go list -m -json
{
	"Path": "example.com/hello",
	"Main": true,
	"Dir": "/tmp/gomoddirectives-repro/hello",
	"GoMod": "/tmp/gomoddirectives-repro/hello/go.mod",
	"GoVersion": "1.18"
}
{
	"Path": "example.com/pkg",
	"Main": true,
	"Dir": "/tmp/gomoddirectives-repro/pkg",
	"GoMod": "/tmp/gomoddirectives-repro/pkg/go.mod",
	"GoVersion": "1.18"
}

[ldez]

can you do a go mod tidy in the hello repo?

[gnuletik]

No I can't. It doesn't work because the modules are not published on fetchable URL, see golang/go#50750

$ go mod tidy
go: finding module for package example.com/pkg
example.com/hello imports
	example.com/pkg: cannot find module providing package example.com/pkg: unrecognized import path "example.com/pkg": reading https://example.com/pkg?go-get=1: 404 Not Found

[ldez]

Fixed by 3ce9a65

[gnuletik]

Works like a charm, thanks :)