Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename use_design_system_item to something more accurate #259

Open
bartekpacia opened this issue Mar 21, 2024 · 3 comments
Open

Rename use_design_system_item to something more accurate #259

bartekpacia opened this issue Mar 21, 2024 · 3 comments

Comments

@bartekpacia
Copy link
Contributor

bartekpacia commented Mar 21, 2024

I think the name of the use_design_system_item lint rule is too specific for what it is actually capable of. It can be used for classes that are not related to design system (though I agree it's the most common use case, and the migration cost probably outweights the (lack of) benefits).

@shilangyu
Copy link
Contributor

What name would you suggest? I am open to changing it if we come up with a good name

@bartekpacia
Copy link
Contributor Author

bartekpacia commented Mar 22, 2024

This lint rule essentially accepts a list of classes, I think the lint name should reflect this – i.e. the name should contain a plural:

Some ideas:

  • class_replacements/replace_classes
  • type_replacements/replace_types (this lint also works for enums/typedefs, right?)
  • custom_type_replacements
Here's what ChatGPT generated Screenshot 2024-03-23 at 00 49 06

@leventkantaroglu
Copy link
Contributor

I suggest the 'avoid-banned-phase-usage' name for this rule.
use_design_system_item is a limiting name. I think any alternative is more preferable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants