Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0 is not reducibly defeq to 1 - 1 if defined via Zero class #2109

Closed
gebner opened this issue Feb 15, 2023 · 2 comments
Closed

0 is not reducibly defeq to 1 - 1 if defined via Zero class #2109

gebner opened this issue Feb 15, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@gebner
Copy link
Member

gebner commented Feb 15, 2023

class Zero (α : Type u) where
  zero : α

instance Zero.toOfNat0 [Zero α] : OfNat α (nat_lit 0) where
  ofNat := Zero.zero

instance : Zero Nat where
  zero := 0  -- this can also be `nat_lit 0`, doesn't make a difference

example : @OfNat.ofNat Nat (nat_lit 0) inferInstance = 1 - 1 := by
  with_reducible rfl -- works

example : @OfNat.ofNat Nat (nat_lit 0) Zero.toOfNat0 = 1 - 1 := by
  with_reducible rfl -- fails

It is very surprising that it works with the default instance, but not if we go via the auxiliary Zero class. Note that we have quite a few lemmas in mathlib which are stated in terms of the Zero instance because they apply generally to additive monoids.

This came up in mathlib: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/isDefEq.20not.20transitive.3F/near/327881064

@gebner gebner added the bug Something isn't working label Feb 15, 2023
@leodemoura
Copy link
Member

@semorrison @jcommelin Is this still an issue in Mathlib? Note that both of examples now fail in master.

@Kha
Copy link
Member

Kha commented Aug 8, 2024

Assuming solved

@Kha Kha closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants