Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue - Possible duplicate Filter input ID / Modal input ID #64

Closed
Nuranto opened this issue Jun 18, 2018 · 0 comments · Fixed by #65
Closed

Issue - Possible duplicate Filter input ID / Modal input ID #64

Nuranto opened this issue Jun 18, 2018 · 0 comments · Fixed by #65
Assignees
Labels
enhancement An enhancement to an existing feature

Comments

@Nuranto
Copy link

Nuranto commented Jun 18, 2018

I had some issues with some JS lib.

I will do short :

  • id of the column filter input is the column name.
  • id of the field in the create/edit modal is the column name. => Duplicate id. (well, this is in my case, I see in your demo you prefixed yours it by input_. However, I'm using blade components for inputs, and it would breaks a lot to change this.).

I think it will be best to prefix the filter's input id to avoid problems.

@leantony leantony added the enhancement An enhancement to an existing feature label Jun 18, 2018
@leantony leantony self-assigned this Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants