Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BNSv2 names not loading in the wallet #5976

Open
314159265359879 opened this issue Nov 19, 2024 · 7 comments
Open

BNSv2 names not loading in the wallet #5976

314159265359879 opened this issue Nov 19, 2024 · 7 comments
Labels
area:bns bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds

Comments

@314159265359879
Copy link
Contributor

314159265359879 commented Nov 19, 2024

When a user sends BNSv2 names to an address
I expect all the names to be loaded and displayed in the wallet
I expect the primary BNS name to become the account name.
It doesn't seem the case.

I know there were some changes made to loading names, to limit calls. I do expect the name to be checked whenever an account is entered (selected on the choose account screen). In this case no matter what the user did, there was no change.

A user is transferring BNSv2 names from several accounts in one wallet to a single account. But the BNS name in account 2 (where he send the first one) is not updating the BNSv2 name even though it should be default primary name (milehighclub.btc).

Image

Current owner is:
SP3Z1PXX27M2W46GG4BBKN1XRJH3WSW186HN9JNF3

I also see this when I try to send STX to milehighclub.btc:
Image

Another odd thing, perhaps related:
The wallet hold 30 BNSv2 names 153 Stacks NFT's in total.

The wallet collectables area is only displaying 27 collectables.

Error logs from console?

Other user has 69 BNS names and 65 are displayed in the wallet. None of the Stacks NFT's are loading in there (6 other Stacks NFT's are present beside the BNSv2 names).
SP381JH1QJKQ35C55332JYW9TNX33AJ81N1NNR581

No console errors, this user does see the name displayed in the wallet, this wallet also has a BNSv1 name.

@314159265359879 314159265359879 added area:bns bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds labels Nov 19, 2024
Copy link

linear bot commented Nov 19, 2024

@314159265359879
Copy link
Contributor Author

Related question: https://trustmachines.slack.com/archives/C07CXAXQ27P/p1731964855537869?thread_ts=1731939013.002879&cid=C07CXAXQ27P

Does the BNSv2 api we use have any rate limits?

@314159265359879
Copy link
Contributor Author

The first user resolved the issue by restoring the wallet again after signing out.

@314159265359879 314159265359879 added bug-p3 Non-critical functionality broken for many users, or there are clear workarounds and removed bug-p2 Critical functionality broken for few users, with no clear workarounds labels Nov 19, 2024
Copy link
Collaborator

camerow commented Nov 21, 2024

@anastasios little issue here with updating a transferred name. I've assigned to next cycle, so feel free to wait until then. If you have time this week though, go for it.

@brandonmarshall-tm
Copy link

Primary name updates and Zonefile updates for BNS names are requiring users to manually Refresh Collectibles in order for the changes to take effect. Wanted to report what seems like may be a similar issue

@Wrenart
Copy link

Wrenart commented Dec 17, 2024

Hello guys, I don’t know if I should be here, I apologise if I am trespassing, But I found the link to here from google when I was trying to troubleshoot a problem I am having. I purchased a couple of Bns names but they do not appear as the account name of the accounts I got them with or transferred to. All my bns v1 names are ok, But none of the V2 ones show on any of my accounts.

@314159265359879
Copy link
Contributor Author

@Wrenart, no problem to post here, you can also email us via support @ leather.io.

You can work around this issue by restoring the wallet with your Secret Key (you can do this after signing out via the top right corner menu), which will force the wallet to check for the names again.

We will work on a better solution for this so that atleast when you enter an account it will update your name if the account received a new name or if the primary name was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:bns bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds
Projects
None yet
Development

No branches or pull requests

4 participants