Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up: Have a dependency-only image hosted on docker hub #87

Closed
MilesCranmer opened this issue Jun 8, 2017 · 2 comments
Closed

Clean-up: Have a dependency-only image hosted on docker hub #87

MilesCranmer opened this issue Jun 8, 2017 · 2 comments
Assignees
Labels

Comments

@MilesCranmer
Copy link
Collaborator

Since the dependencies for Bifrost have remained constant for a while, it seems like it would be more efficient to have a Dockerfile containing just the dependencies (maybe mirrored in another branch so you can pull from docker hub with docker pull ledatelescope/bifrost:deps).

The main Dockerfile would then just have to contain FROM ledatelescope/bifrost:deps, which would make it shorter, and would also mean that local builds would happen faster (you could just pull the dependencies and go). This would make the travis-ci tests faster too, as travis wouldn't have to keep re-building the entire dependency stack.

Docker hub has auto-building functionality on each commit, so we would still see the most up-to-date binaries being pulled.

@MilesCranmer MilesCranmer self-assigned this Jun 8, 2017
@benbarsdell
Copy link
Collaborator

I've been working on some Dockerfile refactoring along these lines that I'll push soon.

@benbarsdell
Copy link
Collaborator

See PR #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants