Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track Sales Person that Raised a Sale vs the one that created the invoice #4318

Closed
sbts opened this issue Dec 30, 2019 · 9 comments
Closed
Labels
type:enhancement Proposed improvement, new feature, or extension -- not a defect waiting-for-user Issue can't progress unless feedback from reporter is received

Comments

@sbts
Copy link
Member

sbts commented Dec 30, 2019

Currently the only user that created an invoice is recorded against the invoice.
In reality we probably should also directly record the person that raised the sale.

ie: The sales person that raised the sale may not be the person entering the invoice and tracking who generated the sale is required to properly handle calculation of bonus payments etc.


I propose we add a field to the invoice screen showing the initiating sales person.
This field should default to

  • The entering user if a stand alone invoice
  • The user from the originating Sales Order
  • any manually selected user

This field should them be stored against the invoice


For example, Sales Team member Jack raises a sales order but Admin staff member Jill receives the PO, and converts the Sales order to an invoice.

Currently this is "sort of" possible as long as there was a sales order generated and the invoice is directly created from the order.
If the above is true, the order number can be used to look up the sales person.

However, the above doesn't work if the sales person provides the goods, or list of goods, and prices to the person entering the invoice via some other means.

@ehuelsmann
Copy link
Member

Currently the only user that created an invoice is recorded against the invoice.
In reality we probably should also directly record the person that raised the sale.

I don't understand this point. The fact that this user gets recorded isn't hard-coded: the person entering the invoice can select another sales person.
Even more: if we don't mark Jill as being a "Salesperson" she won't be available as a selection in the drop-down.

@sbts
Copy link
Member Author

sbts commented Jan 13, 2020

Ok, to clarify, the point is that we should be recording the "entering user" as well as the "Sales User" for all invoices.

In many cases this will be the same person, but in some cases this will be two different people.
The entering user should ALWAYS be the logged in user during entry, while the SALES user would be derived from the rules I outlined above.

MANUAL selection of the sales user should be a last resort to be used only when the order user etc isn't available

@ehuelsmann ehuelsmann added the type:enhancement Proposed improvement, new feature, or extension -- not a defect label May 17, 2020
@ehuelsmann ehuelsmann changed the title enhancement: Track Sales Person that Raised a Sale vs the one that created the invoice Track Sales Person that Raised a Sale vs the one that created the invoice May 17, 2020
@ehuelsmann
Copy link
Member

What do we need the entering user for? Is it that the invoice is a financial transaction and that those need to be auditable?

@sbts
Copy link
Member Author

sbts commented Jun 28, 2020

That's part of it yes.
Also if an error occurs during entry you likely want to know who entered it to coach them to prevent future errors.

If the entering person is not the sales person then it's going to matter that you are coaching the correct person

@ehuelsmann
Copy link
Member

@sbts You are aware that all INSERT/UPDATE/DELETE/etc actions on the AR/AP/GL tables are logged in the audittrail table which also tracks who did what to a transaction, so that we already track who inserted/created the transaction (as well as who approved it, which we track double, because that's also in the "approved_by" field in the transaction)... ?

In that sense, I think this enhancement has been realized already.

@ehuelsmann ehuelsmann added the waiting-for-user Issue can't progress unless feedback from reporter is received label Sep 6, 2020
@sbts
Copy link
Member Author

sbts commented Sep 6, 2020

Ok. That works as far as tracking it goes.
What's missing as far as I'm aware would be the ability to search and sort on the entering user.

I'll have a play when back at home next week to offer a more coherent comment

@no-response no-response bot removed the waiting-for-user Issue can't progress unless feedback from reporter is received label Sep 6, 2020
@ehuelsmann ehuelsmann added the waiting-for-user Issue can't progress unless feedback from reporter is received label Sep 10, 2020
@ehuelsmann
Copy link
Member

There's no presentation at this time of the various modifications of an invoice (including creation), but if that is the actual request, that totally changes the nature of the feature request at hand.

@freelock
Copy link
Member

I would like to propose a different approach to handling this issue -- having a "default" sales person for a credit account.

In our scenario, we are obligated to pay a sales commission on all actual receipts for a particular set of customers for 2 years.

I would like to be able to set a "Salesperson" on the ECA for these customers -- this should be entirely optional.

When a sales order is created, it should set the salesperson to the default for the ECA if it exists, or the current user if it does not.

When an invoice is created, it should set the salesperson to the value in the sales order first, and if that's not set/doesn't exist, the default sales person for the ECA, and only if that's not set, the current user. (Might be nice to even have a permission on this, for who is allowed to override the salesperson on an order).

I see that you can filter on invoices by sales person. So one more step is needed to fully set this up for what I need: enhance the Cash -> Reports -> Receipts screen to report on actual receipts for a time period per sales person. (Or create a new report for this somewhere...)

@sbts would that design meet your needs?

@no-response
Copy link

no-response bot commented Dec 9, 2020

Closing: more than 90 days without user response. Feel free to reopen with your comments.

@no-response no-response bot closed this as completed Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Proposed improvement, new feature, or extension -- not a defect waiting-for-user Issue can't progress unless feedback from reporter is received
Projects
None yet
Development

No branches or pull requests

3 participants