Make it easier to use contentment radio and checkbutton lists in configuration of data sources

[erlando]

Internally Contentment uses its own editors for config. This makes complete sense. Contentment has constants for configuration field aliases and editor view paths but alas they are internal and cannot be used by 3rd party implementations.

I would like to suggest that Constants.Conventions.ConfigurationFieldAliases be made publicly accessible.

It would also be nice if the View member had a static pendant such that you do not have to do things like this
View = _ioHelper.ResolveRelativeOrVirtualUrl(new CheckboxListDataListEditor().View) when setting up a configuration field for a data source. It just seems.... wrong somehow :-)

Lastly, thank you for a very nice package.

[leekelleher]

Thank you for raising this @erlando. In recent years, my general stance with my code is to mark it internal (and often sealed), then when people ask for it to be opened up, then review from there. This is mostly to reduce my own technical debt, as once public, who knows how developers are using it.

Thanks for the prompt, I'm happy to open up some of the constants.

I'll give it some thought on how to best go about it, as my initial thought is not to change the Constants class from internal to public... I'm thinking along the lines of introducing a new static class ContentmentConstants, mostly to avoid naming conflicts with Umbraco's own Constants container class.

[leekelleher]

@erlando Following up on this (a few months later), I've got a pull request ready #375 to add a ContentmentConstants class to expose certain internal constants.

So far it'll have the property-editor aliases, view paths and some of the popular configuration keys/aliases.

Let me know if anything else useful is missing from there. I'll be happy to add more in future (if it makes sense).

The PR will target the next major version, v5 - mostly because that's where my development efforts are currently focused.

[leekelleher]

I've merged in PR #375 for Contentment v5.

[erlando]

Awesome. Thank you for your continued work on this excellent package.