New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escaping attribute does not work sufficient #267

Open

djschilling opened this issue Dec 16, 2022 · 1 comment

djschilling commented Dec 16, 2022 •

edited

Loading

I have the following Code:

const userInput = 'https://heise.de" onmouseover="alert(document.cookie)"';
const html = '<a href="' + xss(userInput) + '">link</a>';

the output of html is the following: '<a href="https://heise.de" onmouseover="alert(document.cookie)"">link</a>'

This leads to an xss Attack. Is this a general problem with this library or am i using it wrong?

The text was updated successfully, but these errors were encountered:

Author

djschilling commented Dec 16, 2022

I figured it out.
Using escapeAttrValue is the correct function for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment