Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[leo_backend_db] Implement status callback for eleveldb #671

Closed
mocchira opened this issue Apr 5, 2017 · 4 comments
Closed

[leo_backend_db] Implement status callback for eleveldb #671

mocchira opened this issue Apr 5, 2017 · 4 comments

Comments

@mocchira
Copy link
Member

mocchira commented Apr 5, 2017

In order to make it easy to debug/monitor I/O activity inside leveldb in detail like the following case.

Providing (Disk Throughput/The number of files) per LSM level using https://github.com/basho/leveldb/blob/2.0.33/db/db_impl.cc#L2113-L2135

If the above information is not enough then also considering to provide whether there is any scheduled compaction using https://github.com/basho/leveldb/blob/2.0.33/db/db_impl.cc#L2404-L2412
We have to add a new I/F in eleveldb in this case (and maybe have to maintain our home grown eleveldb).

Reference: #503 (comment)

@mocchira
Copy link
Member Author

mocchira commented Apr 6, 2017

@yosukehara
I noticed that leo_backend_db_server:status has been used for providing the number of entries stored in a leo_backend_db at https://github.com/leo-project/leo_mq/blob/1.4.13/src/leo_mq_api.erl#L160-L167.
As changing the behavior of leo_backend_db_server:status also requires the changes of leo_mq_api:status,
I think it would be good to implement this feature as another callback function like compaction_status rather than changing the current status semantics. Thoughts?

@yosukehara
Copy link
Member

I think it would be good to implement this feature as another callback function like compaction_status rather than changing the current status semantics. Thoughts?

@mocchira I agree with your opinion. Let's implement its function.

@mocchira
Copy link
Member Author

mocchira commented Apr 6, 2017

@yosukehara thanks. will do with compaction_status.

@yosukehara
Copy link
Member

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants