-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Typescript type definition file #59
Conversation
ISSUES CLOSED: leoforfree#57
b772582
to
24de600
Compare
I can successfully run the tests locally, so I'm not sure why they are failing on CI... Additionally, my changes don't impact the test that's failing. |
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 268 268
=====================================
Hits 268 268 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. I left some comments.
Travis build is green now.
Could you publish a new version to |
it should be automatically don by semantic-release since commit has |
It appears that the
|
That’s a pretty old node version. I’ll look at the Travis config file to set node to the latest. Next will look at the 401. |
🎉 This PR is included in version 5.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Please refer to PR #60 and releases https://github.com/leonardoanalista/cz-customizable/releases |
ISSUES CLOSED: #57
You can now write your config file in Typescript with type safety. Just import the type as normal:
import { Options } from "cz-customizable";