Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Typescript type definition file #59

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

trodi
Copy link
Contributor

@trodi trodi commented Nov 14, 2018

ISSUES CLOSED: #57

You can now write your config file in Typescript with type safety. Just import the type as normal:
import { Options } from "cz-customizable";

@trodi
Copy link
Contributor Author

trodi commented Nov 14, 2018

I can successfully run the tests locally, so I'm not sure why they are failing on CI... Additionally, my changes don't impact the test that's failing.

@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #59   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         268    268           
=====================================
  Hits          268    268

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c8736a...24de600. Read the comment docs.

Copy link
Member

@leonardoanalista leonardoanalista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I left some comments.
Travis build is green now.

@leonardoanalista leonardoanalista merged commit 6d456b0 into leoforfree:master Nov 14, 2018
@trodi trodi deleted the feat-typescript branch November 15, 2018 01:14
@trodi
Copy link
Contributor Author

trodi commented Nov 15, 2018

Could you publish a new version to npm?

@leonardoanalista
Copy link
Member

it should be automatically don by semantic-release since commit has feat: ...

@trodi
Copy link
Contributor Author

trodi commented Nov 15, 2018

It appears that the semantic-release has been failing for recent builds.

Travis Build

> semantic-release pre && npm publish && semantic-release post
npm ERR! publish Failed PUT 401
npm ERR! Linux 4.14.12-041412-generic
npm ERR! argv "/home/travis/.nvm/versions/node/v4.9.1/bin/node" "/home/travis/.nvm/versions/node/v4.9.1/bin/npm" "publish"
npm ERR! node v4.9.1
npm ERR! npm  v2.15.12
npm ERR! code E401
npm ERR! You must be logged in to publish packages. : cz-customizable

@leonardoanalista
Copy link
Member

That’s a pretty old node version. I’ll look at the Travis config file to set node to the latest. Next will look at the 401.

@leonardoanalista
Copy link
Member

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@leonardoanalista
Copy link
Member

Please refer to PR #60 and releases https://github.com/leonardoanalista/cz-customizable/releases
We were using a pre-historic version of semantic release. It should be all back to automated releases from now on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants