Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listCommits – issue with "git log --pretty" delimiter if there is ";" symbols in commits tags #258

Closed
tuchk4 opened this issue Mar 2, 2020 · 0 comments · Fixed by #259

Comments

@tuchk4
Copy link
Contributor

tuchk4 commented Mar 2, 2020

Not a bug, but incorrect behavior

lerna-changelog uses ; as a delimiter for git log --pretty and then split by it to get commit info.

https://github.com/lerna/lerna-changelog/blob/master/src/git.ts#L36

Our CI uses ; symbol for tags labels and automatically adds it to the commits. For example, RC;.;1.164.0.

That's why lerna-changelog can not parse commits properly in out case.

I am going to make PR to fix this.

There are a few options:

  • Add option to set the delimiter symbol
  • Update listCommits function – find another way to get commits info or use RegExp.

I like the way with RegExp.

BTW the same issue will be if use ; in commit messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant