Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tag: v1 #45

Closed
quinnturner opened this issue Aug 24, 2021 · 3 comments
Closed

Add a tag: v1 #45

quinnturner opened this issue Aug 24, 2021 · 3 comments

Comments

@quinnturner
Copy link

Currently, the tag is 1 or 1.0.0. This goes against the typical standard set on GitHub by prefixing with v (including previous releases).

Consider adding a tag v1

@matiasalbarello
Copy link
Contributor

I did not understand what's wrong with https://github.com/lewagon/wait-on-check-action/releases/tag/1.0.0

@quinnturner
Copy link
Author

The previous releases were: wait-on-check@v0.2

Now, the syntax is:
wait-on-check@1

(Noting the missing v). Typically, GitHub releases include the v. Either way, it's good to update the readme with the correct version.

@matiasalbarello
Copy link
Contributor

Thanks @quinnturner! that was a silly mistake from my side. I'm creating the new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants