Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The EPUB is difficult to maintain #64

Closed
petervdonovan opened this issue May 18, 2022 · 5 comments
Closed

The EPUB is difficult to maintain #64

petervdonovan opened this issue May 18, 2022 · 5 comments
Labels
bug Something isn't working question Further information is requested

Comments

@petervdonovan
Copy link
Contributor

In Node 17, the EPUB files produced by streampub are invalid because one of its dependencies is not up to date. An attempt to unzip one of them results in a message such as bad CRC 2cab616f (should be 00000000).

This issue explains where (I think) the issue comes from.

To my knowledge, we have two options:

  1. Do not produce the EPUB. This file format might not be popular enough to justify maintaining the EPUB.
  2. Maintain our own fork of streampub that repairs the problem, and include it here as a submodule. The change required to fix the EPUBs is actually trivial: Just bump the version number of a single dependency. However, if we run into further problems of this sort, then we will probably be on our own to fix them since streampub does not appear to be actively maintained.

Does anyone have an opinion on how to proceed?

@petervdonovan petervdonovan added bug Something isn't working question Further information is requested labels May 18, 2022
@lhstrh
Copy link
Member

lhstrh commented May 18, 2022

What about a third option: submit a PR to the upstream repo?

@edwardalee
Copy link
Contributor

I would be fine with not producing an EPUB version.

@lhstrh
Copy link
Member

lhstrh commented Jun 3, 2022

@petervdonovan: did you end up submitting a PR with streampub? If not, I'd also be fine with letting go of the epub...

@petervdonovan
Copy link
Contributor Author

did you end up submitting a PR with streampub?

Oh, I did submit a PR with them, but it did not go anywhere. I should let go of it and proceed with the PDF generation; that effort just fell by the wayside for a while.

@lhstrh
Copy link
Member

lhstrh commented Dec 14, 2023

We ditched the epub when migrating to docusaurus.

@lhstrh lhstrh closed this as not planned Won't fix, can't repro, duplicate, stale Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants