Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRITICAL for new releases] Missing requirement 'importlib-metadata' #48

Closed
lfwa opened this issue Dec 3, 2022 · 0 comments
Closed
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@lfwa
Copy link
Owner

lfwa commented Dec 3, 2022

The newly updated loggerutil.py requires the package importlib-metadata to log the version of carbontracker that was used. This dependency is not added to pyproject.toml, which means that any new releases from the master branch will be broken (the current PyPi version 1.1.6 is fine since it is based on an old version).

However, if we add importlib-metadata as a dependency then we can no longer support Python 3.6 and instead have to require Python $\geq$ 3.7. Native support of importlib.metadata is also introduced in Python $\geq$ 3.8 without requiring any additional packages, but again that means we have to drop support for Python 3.6 and 3.7.

If we wish to support (the very old) Python 3.6 going forward, an alternative would be to either remove logging of the version number or store it explicitly (and keep it updated through a script on new releases --- not great).

To reiterate, do not issue any new releases from the master branch until this issue is fixed!

@lfwa lfwa added bug Something isn't working help wanted Extra attention is needed labels Dec 3, 2022
@PedramBakh PedramBakh self-assigned this Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants