got audio is undefined when componentWillUnmount

[JackHuang16]

hi
I got audio variation is undefined when componentWillUnmount.

it happened in CurrentTime.js, Duration.js, ProgressBar.js, and VolumeBar.js when componentWillUnmount

and I change it to this, everything goes fine.

CurrentTime.js
`
_proto.componentWillUnmount = function componentWillUnmount() {
var audio = this.props.audio;

if( audio && this.hasAddedAudioEventListener ) {
  audio.removeEventListener('timeupdate', this.handleAudioCurrentTimeChange);
  audio.removeEventListener('loadedmetadata', this.handleAudioCurrentTimeChange);
  this.hasAddedAudioEventListener = false;
}

};
`

Duration.js
`
_proto.componentWillUnmount = function componentWillUnmount() {
var audio = this.props.audio;

if (audio && this.hasAddedAudioEventListener) {
  audio.removeEventListener('durationchange', this.handleAudioDurationChange);
  this.hasAddedAudioEventListener = false;
}

};
`

VolumeBar.js
`
_proto.componentWillUnmount = function componentWillUnmount() {
var audio = this.props.audio;

if (audio && this.hasAddedAudioEventListener) {
  audio.removeEventListener('volumechange', this.handleAudioVolumeChange);
  this.hasAddedAudioEventListener = false;
}
clearTimeout(this.volumeAnimationTimer);

};
`

ProgressBar.js
`
_proto.componentWillUnmount = function componentWillUnmount() {
var audio = this.props.audio;

if (audio && this.hasAddedAudioEventListener) {
  audio.removeEventListener('timeupdate', this.handleAudioTimeUpdate);
  audio.removeEventListener('progress', this.handleAudioDownloadProgressUpdate);
  this.hasAddedAudioEventListener = false;
}

clearTimeout(this.downloadProgressAnimationTimer);

};
`

please check it

Thanks a lot : )

[lhz516]

Thanks for reporting. Which package version is it? How do you reproduce this exactly?

[JackHuang16]

My version is ^2.4.1.
I have a search bar for users to input, then call the API to present the result with react-h5-audio-player.
The first time is no problem, but when the user search again, it will crash by that.

Thanks

[lhz516]

The fix is easy but I can't reproduce that and don't know the root cause.

I just published 2.4.2-beta.0 and 2.4.2-beta.1 using two different ways.

Could you check if both work for you or only the second one works for you? After that I'll publish the formal 2.4.2

[JackHuang16]

only 2.4.2-beta.1 worked fine in my scenario
2.4.2-beta.0 still got the same error
thanks a lot : )

[lhz516]

Thanks for testing. Published 2.4.2. Closing